chore: sync fsRead with VSC branch. #936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
approved these changes
Apr 9, 2025
kmile
reviewed
Apr 11, 2025
| agent.addTool(fsReadTool.getSpec(), async (input: FsReadParams) => { | ||
| // TODO: fill in logic for handling invalid tool invocations | ||
| // TODO: implement chat streaming via queueDescription. | ||
| await fsReadTool.validate(input) |
Contributor
There was a problem hiding this comment.
This will throw errors to be handled by the chatController (which I think is fine, but good to be aware of).
Contributor
Author
There was a problem hiding this comment.
Yeah I wasn't sure if this should be handled in the handler or in the chatController itself which is why I added the comment.
However, I imagine handling these agent errors in one place and allowing handlers to throw is better design, so good call out!
kmile
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The fsRead tool has had changes since #894 was merged. Additionally, the
validateandinvokemethods were combined previously, but have been separated here until the final implementation is more stable, and refactoring can be done with less churn.Solution
queueDescriptionfunction.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.